dashboard(results): adapt target_error_kind reader to slim index rows - #1701
Merged
Conversation
index.jsonl rows dropped the inline target_execution envelope in favor of a compact target_error_kind scalar (av-cpl5.3). Dashboard's ResultTable read the old nested shape only, so the target-error-kind badge went dark for new runs. Wire target_error_kind through serve.ts's row read-model (with a fallback to the legacy nested target_execution.error_kind/errorKind for older fat bundles) and fix the Dashboard-side helper to prefer the new field. av-cpl5.1
Deploying agentv with
|
| Latest commit: |
031c9fe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://99579b00.agentv.pages.dev |
| Branch Preview URL: | https://cpl5-dashboard.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
av-cpl5.1(leaf of parent trackerav-cpl5): adapt Dashboard/CLI result readers to the slimsummary.json/index.jsonlshapes shipped ina983924e(cases→tests rename) and16a21b33(target_execution/transcript_summary → sidecars).Investigation found most readers (
manifest.ts,export.ts,projection-bundle.ts,summary.ts,report.ts) never referenced the removedcases[]/total_cases/total_instancessummary fields or the row-leveltarget_execution/transcript_summaryfields directly, so no changes were needed there.summaryRunId()in core already has therun_idroot/metadata fallback. The trial-level (samples[])transcript_summarysidecar fallback inserve.ts'sbuildRepeatTrialReadModelsalready covered the new schema (readsresult.jsonwhen absent inline).The one real gap: Dashboard's
ResultTable.tsxtargetErrorKind()helper only read the old nestedtarget_execution.error_kind/errorKindshape, andserve.ts's row read-model never actually passed a row-level target-error signal through to the client at all (for non-repeat rows) — so this was silently broken even before the schema change.apps/cli/src/commands/results/manifest.ts: typetarget_error_kind(new) and legacytarget_execution(fat-row fallback) onResultManifestRecord.apps/cli/src/commands/results/serve.ts: addrecordTargetErrorKind()compat adapter and wire it intoattachRunDetailReadModelFieldssoresults[].target_error_kindis populated from either the new compact field or the legacy nested envelope.apps/dashboard/src/lib/types.ts: addtarget_error_kindtoEvalCaseTrial/EvalResult.apps/dashboard/src/components/ResultTable.tsx:targetErrorKind()now preferstarget_error_kind, falling back to the legacy nested shape.serve.test.ts(API-level) andResultTable.test.tsx(render-level).Verification
bun run build && bun run typecheck— clean.node_modules/.bin/biome checkon touched files — clean.apps/cli/test/commands/results/**(249 pass),apps/dashboard/src/lib/result-table.test.ts+ResultTable.test.tsx+transcript-timeline.test.tsx(26 pass).examples/features/rubric/evals/operators.eval.yaml) against a live Azure OpenAI target with a livellm-rubricgrader. Confirmed the producedsummary.jsonhas the slim shape (tests[],total_tests/passed_tests/failed_tests, nometadata.run_id) and.internal/index.jsonlrows have notarget_execution/transcript_summary. Verifiedagentv results show/summary/reportall work against the bundle.agentv dashboard, confirmed/api/runsand/api/runs/:idrender the live bundle correctly.cases[]summary + row-leveltarget_execution.error_kind) and confirmed/api/runs/:idcorrectly derivestarget_error_kind: "timeout"via the new compat fallback.serve.ts/ResultTable.tsxchange, this same legacy-bundle scenario returned no error-kind signal to the client at all — confirmed by inspectingattachRunDetailReadModelFieldsprior to the fix.Test plan
bun run buildbun run typecheckbun test apps/cli/test/commands/results/(249 pass)bun test apps/dashboard/src/lib/result-table.test.ts apps/dashboard/src/components/ResultTable.test.tsx apps/dashboard/src/components/transcript-timeline.test.tsx(26 pass)results show/summary/report🤖 Generated with Claude Code